only reallocate when full

2 files changed, 6 insertions, 3 deletions

diff --git a/package.xml b/package.xml
index 59c2bb5..2e88f71 100644
--- a/package.xml
+++ b/package.xml
@@ -24,7 +24,7 @@ Documentation: https://www.php.net/rpminfo
   </stability>
   <license>PHP 3.01</license>
   <notes>
-- generate arginfo from stub
+- generate arginfo from stub and add missing default values
 - raise dependency on PHP 7.2
   </notes>
   <contents>
diff --git a/rpminfo.c b/rpminfo.c
index fa5a8de..3aa7e36 100644
--- a/rpminfo.c
+++ b/rpminfo.c
@@ -36,6 +36,7 @@
 #define ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(pass_by_ref, name, type_hint, allow_null, default_value) \
         ZEND_ARG_TYPE_INFO(pass_by_ref, name, type_hint, allow_null)
 #endif
+
 #include "rpminfo_arginfo.h"
 
 ZEND_DECLARE_MODULE_GLOBALS(rpminfo)
@@ -510,8 +511,10 @@ PHP_FUNCTION(rpmaddtag)
 				RETURN_BOOL(0);
 			}
 		}
-		RPMINFO_G(max_tags) += 16;
-		RPMINFO_G(tags) = erealloc(RPMINFO_G(tags), RPMINFO_G(max_tags) * sizeof(rpmTagVal));
+		if (RPMINFO_G(nb_tags) == RPMINFO_G(max_tags)) {
+			RPMINFO_G(max_tags) += 16;
+			RPMINFO_G(tags) = erealloc(RPMINFO_G(tags), RPMINFO_G(max_tags) * sizeof(rpmTagVal));
+		}
 	} else {
 		RPMINFO_G(max_tags) = 16;
 		RPMINFO_G(tags) = emalloc(RPMINFO_G(max_tags) * sizeof(rpmTagVal));